JuliaGraphs / GraphPlot.jl

Graph visualization for Julia.
http://JuliaGraphs.github.io/GraphPlot.jl/
Other
201 stars 62 forks source link

Update plot.jl #128

Closed davide-f closed 3 years ago

davide-f commented 4 years ago

Dear community,

I propose this pull request that: 1) add a custom line dash style of the edges (solve #127 ) 2) specify whether to resize the box as a unit square or preserve the proportions (x and y axes) among the different stations

What do you think?

Davide

codecov[bot] commented 4 years ago

Codecov Report

Merging #128 into master will increase coverage by 0.43%. The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   33.26%   33.70%   +0.43%     
==========================================
  Files           9        9              
  Lines         526      534       +8     
==========================================
+ Hits          175      180       +5     
- Misses        351      354       +3     
Impacted Files Coverage Δ
src/plot.jl 62.10% <73.33%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ce59f9...608552b. Read the comment docs.

simonschoelly commented 3 years ago

Is it possible to create two separate PRs for both of these features? While I am on board with the dashed lines (although we might need some changes there), I haven't really thought about non-square plots yet.

davide-f commented 3 years ago

Ok, I'll do that