search

JuliaGraphs / GraphPlot.jl

Graph visualization for Julia.
http://JuliaGraphs.github.io/GraphPlot.jl/
Other
201 stars 62 forks source link

Migrate from LightGraphs to Graphs.jl #158

Closed simonschoelly closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #158 (139d4e9) into master (b2a5b0b) will decrease coverage by 0.34%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   33.26%   32.92%   -0.35%     
==========================================
  Files           9        9              
  Lines         526      565      +39     
==========================================
+ Hits          175      186      +11     
- Misses        351      379      +28
Impacted Files Coverage Δ
src/GraphPlot.jl 100.00% <ø> (ø)
src/collapse_plot.jl 0.00% <0.00%> (ø)
src/deprecations.jl 0.00% <0.00%> (ø)
src/layout.jl 48.42% <0.00%> (+1.75%) :arrow_up:
src/lines.jl 52.22% <0.00%> (-0.12%) :arrow_down:
src/stress.jl 0.00% <0.00%> (ø)
src/pienode.jl 0.00% <0.00%> (ø)
src/plot.jl 62.63% <0.00%> (+0.56%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2a5b0b...139d4e9. Read the comment docs.

simonschoelly commented 2 years ago

I would make it a breaking change, therefore version 0.5.0. GraphPlot.jl is apparently a dependency of more than twenty packages, so if we don't make it breaking it could silently update and break something as long as they still have LightGraphs as another dependency. Basically the same issue as we have with SimpleWeightedGraphs now.