search

JuliaGraphs / GraphPlot.jl

Graph visualization for Julia.
http://JuliaGraphs.github.io/GraphPlot.jl/
Other
201 stars 62 forks source link

Update plot.jl to account for line style #176

Open etiennedeg opened 2 years ago

etiennedeg commented 2 years ago

This is a rebase of #131, after I messed it up. I added some documentation

codecov[bot] commented 2 years ago

Codecov Report

Merging #176 (f108307) into master (2ce59f9) will decrease coverage by 0.23%. The diff coverage is 6.06%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   33.26%   33.03%   -0.24%     
==========================================
  Files           9        9              
  Lines         526      566      +40     
==========================================
+ Hits          175      187      +12     
- Misses        351      379      +28
Impacted Files Coverage Δ
src/GraphPlot.jl 100.00% <ø> (ø)
src/collapse_plot.jl 0.00% <0.00%> (ø)
src/deprecations.jl 0.00% <0.00%> (ø)
src/layout.jl 48.42% <0.00%> (+1.75%) :arrow_up:
src/plot.jl 63.04% <100.00%> (+0.97%) :arrow_up:
src/lines.jl 52.22% <0.00%> (-0.12%) :arrow_down:
src/stress.jl 0.00% <0.00%> (ø)
src/pienode.jl 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

hdavid16 commented 2 years ago

@etiennedeg, thanks for moving things with this old PR. what is the status of this PR?

etiennedeg commented 2 years ago

I don't know what is the policy on this package for testing, maybe we need some kind of tests, but I don't see many tests here. Otherwise, I think we are good. @simonschoelly, a quick review maybe ?

hdavid16 commented 2 years ago

If it helps, I can add this to #186 so that it is consistent with straight and curved lines with the new fixes that enable curved self-loops. And we can have one PR with all these feature additions.