JuliaGraphs / GraphPlot.jl

Graph visualization for Julia.
http://JuliaGraphs.github.io/GraphPlot.jl/
Other
200 stars 62 forks source link

Allow setting a background color for a gplot (included in PR #186) #178

Closed hdavid16 closed 1 year ago

hdavid16 commented 1 year ago

Fixes #172

codecov[bot] commented 1 year ago

Codecov Report

Merging #178 (074ce86) into master (52f4aae) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   32.92%   32.92%           
=======================================
  Files           9        9           
  Lines         565      565           
=======================================
  Hits          186      186           
  Misses        379      379           
Impacted Files Coverage Δ
src/plot.jl 62.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

simonschoelly commented 1 year ago

Would it be possible to add a test for the background color option?

hdavid16 commented 1 year ago

Would it be possible to add a test for the background color option?

I just added a fourth test in the karate test, where the background color is set to lightyellow