search

JuliaGraphs / Graphs.jl

An optimized graphs package for the Julia programming language
http://juliagraphs.org/Graphs.jl/
Other
459 stars 91 forks source link

Revert the error thrown by badj to NotImplementedError #262

Closed simonschoelly closed 1 year ago

simonschoelly commented 1 year ago

This PR reverts the change that was done to badj in #249 , as apparently it is not necessary to change the error in order to satisfy JET.jl.

There are still some good arguments for and also against throwing a custom error message when an interface method is not implemented, but I think that needs a separate discussion as we still have the pattern where we throw NotImplementedError in various places, so we should not simply change it for that single function.

codecov[bot] commented 1 year ago

Codecov Report

Merging #262 (bc5dd54) into master (6756864) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         114      114           
  Lines        6579     6580    +1     
=======================================
+ Hits         6399     6400    +1     
  Misses        180      180
gdalle commented 1 year ago

Opened an issue in the new API repo to track this