search

JuliaGraphs / Graphs.jl

An optimized graphs package for the Julia programming language
http://juliagraphs.org/Graphs.jl/
Other
459 stars 91 forks source link

Test cycles with generic graph #274

Closed simonschoelly closed 1 year ago

simonschoelly commented 1 year ago

This PR makes the tests for the cycles algorithm use GenericGraph

Currently the algorithms in src/cycles/incremental.jl and src/cycles/johnson.jl do not work with generic graphs - this is, because they relay on modifying graph functions. At least for johnson this might be fixable but for incremental it seems to be necessary to have modifiable graphs.

In addition, this PR changes the function cycle_basis so that it accepts an arbitrary AbstractGraph instead of just an AbstractSimpleGraph.

codecov[bot] commented 1 year ago

Codecov Report

Merging #274 (8aad8dc) into master (d29e1f2) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   97.19%   97.20%   +0.01%     
==========================================
  Files         114      114              
  Lines        6658     6658              
==========================================
+ Hits         6471     6472       +1     
+ Misses        187      186       -1
gdalle commented 1 year ago

Partial solution to #224