search

JuliaGraphs / Graphs.jl

An optimized graphs package for the Julia programming language
http://juliagraphs.org/Graphs.jl/
Other
459 stars 91 forks source link

Fix formatting for file vf2.jl and remove `ignore` in test + autoformatter pass #323

Closed gdalle closed 9 months ago

gdalle commented 9 months ago

PR #190 introduced a BlueStyle formatting check, but back then the file src/Experimental/vf2.jl caused problems to JuliaFormatter. So it was ignored as follows: format(Graphs; ignore=["vf2.jl"]).

Some time later, PR #210 changed this to format(Graphs; ignore="vf2.jl"), which seems to also have ignored a lot of other files. The reasons are a bit unclear to me.

I checked again, and now JuliaFormatter can handle src/Experimental/vf2.jl without erroring. I removed the ignore keyword in the test, and reformatted all the files that had been overlooked since #210.

The only meaningful changes are in test/runtests.jl and src/Experimental/vf2.jl, the rest is just JuliaFormatter doing its thing.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (da6f801) 97.26% compared to head (fb0b95a) 97.26%.

Files Patch % Lines
src/traversals/eulerian.jl 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #323 +/- ## ======================================= Coverage 97.26% 97.26% ======================================= Files 115 115 Lines 6795 6796 +1 ======================================= + Hits 6609 6610 +1 Misses 186 186 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 9 months ago

@mcognetta available for a quick review? This is mostly formal