search

JuliaGraphs / Graphs.jl

An optimized graphs package for the Julia programming language
http://juliagraphs.org/Graphs.jl/
Other
459 stars 91 forks source link

Put formal tests (Aqua, JET, JuliaFormatter) inside the main test set #330

Closed gdalle closed 7 months ago

gdalle commented 8 months ago

Upside: CI does not terminate if the code fails Aqua / JET / JuliaFormatter / Documenter tests, and can run the test suite until the end to detect other errors Downside: the full test suite will always be run, including when JET can guarantee something will go wrong

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a1ea44e) 97.28% compared to head (f0d3c17) 97.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #330 +/- ## ======================================= Coverage 97.28% 97.28% ======================================= Files 115 115 Lines 6789 6789 ======================================= Hits 6605 6605 Misses 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simonschoelly commented 8 months ago

This makes sense to me. But why is there now also a broken doctest?

gdalle commented 7 months ago

where do you see that? the tests are passing on 1.10, aren't they?

simonschoelly commented 7 months ago

I meant, during the nightly run we see now Documenter failing (although I don't understand why) - It is very much possible that this would have already been the case before but it was hidden because the test would not run further than JET.

gdalle commented 7 months ago

I think that is due to unstable RNGs between Julia versions, which is why doctests should probably use StableRNGs.jl. One more argument for merging this, if you approve the PR? I just opened https://github.com/JuliaGraphs/Graphs.jl/issues/341 to keep track of the doctest issue

gdalle commented 7 months ago

thanks!