Closed henrik-wolf closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f6f8db6
) 97.28% compared to head (11fe08f
) 97.28%. Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some notes:
* DocStringExtensions.jl might be a good tool in the future to automatically generate typed signatures in the docstrings and avoid this uncertainty
Afaik it is not always recommended to put the type signature in the doc string. This is anyways a special case, because Integer
as subtype of a Real
leads to a different behavior - something that I don't think is very desirable.
I added typed-definitions to the docstring of
erdos_renyi
, as we differentiate the two different definitions of the Erdös-Rényi ensemble by dispatching on the type of the second argument.As I spent some time with the strange edge case of
erdos_renyi(n, 1) != erdos_renyi(n , 1.0)
today this feels like a good idea.