Closed filchristou closed 4 months ago
Thanks for the PR, I'll review soon. In accordance with the ColPrac guidelines, please don't push directly and instead open a PR + wait for review if you want to change the master branch.
ok, btw is it normal that the CI fails so hard and that the nighly is still in progress after 3 hours ?
Nightly is unpredictable, but the rest is not normal no
It's the formatting
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.29%. Comparing base (
7133460
) to head (e13a171
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@gdalle thanks for the review. Please mark all discussions you are satisfied with as "resolved". When all are resolved I will make the changes.
Following ColPrac @filchristou you can merge your own PR after review since you have the rights
as discussed in the community call, the trigger workflow file needs to be in the default, i.e. master, branch.
I guess I shouldn't push directly to master, so I made this PR, but maybe for future iterations it makes more sense if I can push directly. That might create some commits, but as already discussed they are not user critical since changes are only made to the CI.