JuliaGraphs / Graphs.jl

An optimized graphs package for the Julia programming language
http://juliagraphs.org/Graphs.jl/
Other
451 stars 87 forks source link

Bringing the `.github/workflows/postbench.yml` to master #350

Closed filchristou closed 4 months ago

filchristou commented 4 months ago

as discussed in the community call, the trigger workflow file needs to be in the default, i.e. master, branch.

I guess I shouldn't push directly to master, so I made this PR, but maybe for future iterations it makes more sense if I can push directly. That might create some commits, but as already discussed they are not user critical since changes are only made to the CI.

gdalle commented 4 months ago

Thanks for the PR, I'll review soon. In accordance with the ColPrac guidelines, please don't push directly and instead open a PR + wait for review if you want to change the master branch.

filchristou commented 4 months ago

ok, btw is it normal that the CI fails so hard and that the nighly is still in progress after 3 hours ?

gdalle commented 4 months ago

Nightly is unpredictable, but the rest is not normal no

gdalle commented 4 months ago

It's the formatting

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.29%. Comparing base (7133460) to head (e13a171). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #350 +/- ## ======================================= Coverage 97.28% 97.29% ======================================= Files 115 117 +2 Lines 6789 6814 +25 ======================================= + Hits 6605 6630 +25 Misses 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

filchristou commented 4 months ago

@gdalle thanks for the review. Please mark all discussions you are satisfied with as "resolved". When all are resolved I will make the changes.

gdalle commented 4 months ago

Following ColPrac @filchristou you can merge your own PR after review since you have the rights