search

JuliaGraphs / Graphs.jl

An optimized graphs package for the Julia programming language
http://juliagraphs.org/Graphs.jl/
Other
451 stars 87 forks source link

Remove CI on nightly #374

Closed gdalle closed 2 months ago

gdalle commented 2 months ago

Fix #295

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.27%. Comparing base (599ef81) to head (2cc587e). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #374 +/- ## ======================================= Coverage 97.27% 97.27% ======================================= Files 118 118 Lines 6874 6874 ======================================= Hits 6687 6687 Misses 187 187 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

etiennedeg commented 2 months ago

What does the allow failure do if the tests still error when nightly errors?

gdalle commented 2 months ago

I think it does at least allow the CI badge on README to be green, but I'm not sure of the internals. See https://discourse.julialang.org/t/ignoring-nightly-failure-for-ci-badge/98028/5?u=gdalle for a discussion

Beyond the green checks and red crosses, it also comes down to a philosophical issue of whether we should test on nightly or not. I'd be favorable to testing on the next release candidate as soon as it comes out instead, because it's likely to be more polished and e.g. not make JET or Aqua fail