JuliaGraphs / Graphs.jl

An optimized graphs package for the Julia programming language
http://juliagraphs.org/Graphs.jl/
Other
451 stars 87 forks source link

Fix bfs iterator for multiple source nodes #382

Closed Tortar closed 1 month ago

Tortar commented 1 month ago

I noticed that the previous implementation of multi source bfs was wrong, because it didn't start with the first level nodes (also my fault :( ), this should be correct instead, and also faster than the one in #381. I see a 1.7x improvement over the previous version on a erdos_renyi(1000000, 0.00001) starting from a random node.

There is still a problem though, I think multi-source dfs suffers from a similar problem. But I unfortunately don't have time to fix it at the moment.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.31%. Comparing base (43f9f18) to head (5d1275c). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #382 +/- ## ========================================== - Coverage 97.31% 97.31% -0.01% ========================================== Files 120 120 Lines 6954 6953 -1 ========================================== - Hits 6767 6766 -1 Misses 187 187 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tortar commented 1 month ago

Gentle bump

Tortar commented 1 month ago

Hi @gdalle @simonschoelly sorry for the ping but I think this one would be good for a patch version release, if you have some time to spend reviewing it