JuliaGraphs / LightGraphsExtras.jl

Additional functionality for LightGraphs.jl
Other
21 stars 13 forks source link

need to update for julia 0.5 #13

Closed CarloLucibello closed 7 years ago

CarloLucibello commented 7 years ago

I'm taking care of this

CarloLucibello commented 7 years ago

@jpfairbanks looks like once I checkout the "0.5-update" branch of graph matrices most problems are solved, except for A_mul_B not defined for the Nonbacktracking type defined here. Can you define take a look at this?

jpfairbanks commented 7 years ago

Yeah the problem is that when we define * in 0.4 we need to also define A_mul_B in 0.5. https://github.com/JuliaGraphs/LightGraphs.jl/blob/master/src/spectral.jl#L239 is the relevant definition.

function A_mul_B!(C, nbt::Nonbacktracking, B)
    # computs C = A*B
    for i in 1:size(B,2)
        C[:,i] = A*B[:,i]
    end
    return C
end

this code should probably go into the spectral.jl file of lightgraphs.

CarloLucibello commented 7 years ago

@sbromberger do we have any schedule for the next LG tag? can't release a LGExtras 0.5 compatible version until that

sbromberger commented 7 years ago

I was waiting for @jpfairbanks to finish the LinAlg submodule. If that looks like it's going to be delayed past this weekend I will tag a new version on Sunday.

sbromberger commented 7 years ago

Closing this out since we've merged #20 and a new tag is in progress.