search

JuliaGraphs / LightGraphsExtras.jl

Additional functionality for LightGraphs.jl
Other
21 stars 13 forks source link

should we drop support to GraphMatrices? #3

Closed CarloLucibello closed 7 years ago

CarloLucibello commented 7 years ago

We are keeping the dependence from a package not actively maintained and also causing troubles with julia 0.5, for this single function

function CombinatorialAdjacency(g::Graph)
    d = float(indegree(g))
    return GraphMatrices.CombinatorialAdjacency{Float64, typeof(g), typeof(d)}(g,d)
end

I'd say, let just insert the above lines in the documentation of LightGraphs, and let the users define CombinatorialAdjacency by themeselves if they need to.

Thoughts? @jpfairbanks @sbromberger

sbromberger commented 7 years ago

I'd like it fixed rather than removing it, but if @jpfairbanks isn't planning on moving it to 0.5, perhaps we need to.

jpfairbanks commented 7 years ago

I am planning to update to 0.5. Just have a lot going on. What is causing the failures?

On Sat, Jul 30, 2016 at 12:20 PM, Seth Bromberger notifications@github.com wrote:

I'd like it fixed rather than removing it, but if @jpfairbanks https://github.com/jpfairbanks isn't planning on moving it to 0.5, perhaps we need to.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaGraphs/LightGraphsExtras.jl/issues/3#issuecomment-236374275, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoFzsi2L5gELdIXLwI25ffCtrAgLvMYks5qa3m_gaJpZM4JYyWo .

James Fairbanks, PhD School of Computational Science and Engineering Georgia Tech

sbromberger commented 7 years ago

I'll close this out because I think we've decided to keep GraphMatrices. @jpfairbanks - I'll try to get a PR or two to clean up the warning messages. It might be as simple as tagging a new version.

Oh, I just remembered - we're going to incorporate GM into LGE natively. Never mind. This should still be closed.