search

JuliaGraphs / LightGraphsExtras.jl

Additional functionality for LightGraphs.jl
Other
21 stars 13 forks source link

Signature parameters #32

Closed matbesancon closed 6 years ago

matbesancon commented 6 years ago

PR on top of https://github.com/JuliaGraphs/LightGraphsExtras.jl/pull/29 updating the syntax for Julia 0.6 and using <:Edge for the edge type, since Edge itself is parametrized (see https://github.com/JuliaGraphs/LightGraphsExtras.jl/issues/31)

sbromberger commented 6 years ago

Problem's now in interdiction.

matbesancon commented 6 years ago

Yes I noticed so but couldn't figure out the point where the failure happens

matbesancon commented 6 years ago

Yes I noticed so but couldn't figure out the point where the failure happens

sbromberger commented 6 years ago

https://travis-ci.org/JuliaGraphs/LightGraphsExtras.jl/jobs/322716397#L4700-L4706

ERROR: LoadError: LoadError: No solver was provided. JuMP has classified this model as LP. Julia packages which provide solvers for this class of problems include Clp, GLPKMathProgInterface, Gurobi, CPLEX, Mosek, and Xpress. The solver must be specified by using either the "solver=" keyword argument to "Model()" or the "setsolver()" method.
Stacktrace:
 [1] no_solver_error(::JuMP.ProblemTraits) at /home/travis/.julia/v0.6/JuMP/src/solvers.jl:84
 [2] #build#119(::Bool, ::Bool, ::JuMP.ProblemTraits, ::Function, ::JuMP.Model) at /home/travis/.julia/v0.6/JuMP/src/solvers.jl:298
 [3] (::JuMP.#kw##build)(::Array{Any,1}, ::JuMP.#build, ::JuMP.Model) at ./<missing>:0
 [4] #solve#116(::Bool, ::Bool, ::Bool, ::Array{Any,1}, ::Function, ::JuMP.Model) at /home/travis/.julia/v0.6/JuMP/src/solvers.jl:168
 [5] bilevel_adaptive_arc(::LightGraphs.SimpleGraphs.SimpleDiGraph{Int64}, ::Int64, ::Int64, ::Array{Float64,2}, ::Int64, ::JuMP.UnsetSolver, ::Float64, ::Float64, ::Float64) at /home/travis/.julia/v0.6/LightGraphsExtras/test/../src/interdiction/bilevel_adaptive_arc.jl:114

Looks like we now need to specify a solver for functions?

matbesancon commented 6 years ago

This should do it. JuMP wanted a LP solver for the problems of the test suite, I didn't know if all problems would be LP or if others would be MIP. In the doubt, I considered MIP as the default solver. This allows for keeping only one solver as dependency (same as in matching)

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5f27119). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #32   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     13           
  Lines             ?    207           
  Branches          ?      0           
=======================================
  Hits              ?    207           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/matching/matching.jl 100% <ø> (ø)
src/interdiction/adaptive_path.jl 100% <ø> (ø)
src/interdiction/bilevel_adaptive_path.jl 100% <ø> (ø)
src/interdiction/network_interdiction.jl 100% <ø> (ø)
src/interdiction/bilevel_network_interdiction.jl 100% <ø> (ø)
src/interdiction/multilink_attack.jl 100% <ø> (ø)
src/interdiction/bilevel_adaptive_arc.jl 100% <ø> (ø)
src/interdiction/adaptive_arc.jl 100% <ø> (ø)
src/matching/maximum_weight_matching.jl 100% <100%> (ø)
src/matching/lp.jl 100% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f27119...c9573b1. Read the comment docs.

sbromberger commented 6 years ago

That did it!