JuliaGraphs / LightGraphsFlows.jl

Flow algorithms on LightGraphs

Other

36 stars 11 forks source link

Added fixes for Julia 1.0 #19

Closed simonschoelly closed 5 years ago

simonschoelly commented 6 years ago

Most of the stuff works, but the package Clp.jl is not yet ready for version 1.0. Therefore the tests fail and mincost_flow does not work yet.

Should also remove most of the warnings in #18

matbesancon commented 6 years ago

oh wonderful thanks! For the parametric functions I'm not sure SimpleTraits.jl supports the where syntax

matbesancon commented 6 years ago

Also, I think we can change the travis config:

julia:
  - 0.7
  - 1.0
  - nightly

matrix:
  allow_failures:
- julia: nightly

simonschoelly commented 6 years ago

I changed the travis config. There is also appveyor config that defaults to version 0.6 but I'm not familiar with that. SimpleTraits does support the where syntax, you just have to be a bit careful when you have multiple arguments in the where clause.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling dd2424273fc0570516f651aaf0b171e9fc4dc0c6 on simonschoelly:fixes_for_v1.0 into c64661c9062f4629d5189f015d37fd71ad905a6c on JuliaGraphs:master.

matbesancon commented 6 years ago

To update appveyor if you can: https://github.com/JuliaCI/Appveyor.jl The readme example is up to date for 1.0, copy-pasting should just work, uncomment the nightly fail allowed and we're god

codecov[bot] commented 6 years ago

Codecov Report

Merging #19 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #19    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          11     10     -1     
  Lines         419    280   -139     
======================================
- Hits          419    280   -139

Impacted Files	Coverage Δ
src/ext_multiroute_flow.jl	`100% <ø> (ø)`	:arrow_up:
src/push_relabel.jl	`100% <ø> (ø)`	:arrow_up:
src/dinic.jl	`100% <100%> (ø)`	:arrow_up:
src/maximum_flow.jl	`100% <100%> (ø)`	:arrow_up:
src/boykov_kolmogorov.jl	`100% <100%> (ø)`	:arrow_up:
src/edmonds_karp.jl	`100% <100%> (ø)`	:arrow_up:
src/mincost.jl	`100% <0%> (ø)`	:arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c64661c...dd24242. Read the comment docs.

simonschoelly commented 6 years ago

Appveyor is running now but Windows has problems with clp on all versions. The other tests all pass: https://ci.appveyor.com/project/simonschoelly/lightgraphsflows-jl/build/1.0.10

matbesancon commented 6 years ago

yes clp is supposedly good on 0.7, not sure about 1.0 they didn't put it in their CI scripts, I'll PR them for it

matbesancon commented 6 years ago

https://github.com/JuliaOpt/Clp.jl/pull/32

juliohm commented 6 years ago

Thank you @simonschoelly for your work. What is the status?

simonschoelly commented 6 years ago

Until Clp.jl and Cbc.jl, which is a dependency for the former, work on 1.0, the tests can't pass.

See JuliaOpt/Clp.jl#31 and JuliaOpt/Cbc.jl#54.

simonschoelly commented 5 years ago

Clp runs on Julia v1.0 now, so this PR could probably be merged.

matbesancon commented 5 years ago

Wonderful, merging as soon as CI passes, thanks @simonschoelly !