search

JuliaGraphs / LightGraphsFlows.jl

Flow algorithms on LightGraphs
Other
36 stars 11 forks source link

correcting mincut #32

Closed etiennedeg closed 4 years ago

etiennedeg commented 4 years ago

Fixes :

https://github.com/JuliaGraphs/LightGraphsFlows.jl/issues/27

codecov[bot] commented 4 years ago

Codecov Report

Merging #32 into master will increase coverage by 32.6%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   65.65%   98.25%   +32.6%     
==========================================
  Files          10       10              
  Lines         428      287     -141     
==========================================
+ Hits          281      282       +1     
+ Misses        147        5     -142
Impacted Files Coverage Δ
src/mincut.jl 100% <100%> (+7.69%) :arrow_up:
src/maximum_flow.jl 75% <0%> (+6.81%) :arrow_up:
src/multiroute_flow.jl 100% <0%> (+9.52%) :arrow_up:
src/ext_multiroute_flow.jl 100% <0%> (+20%) :arrow_up:
src/kishimoto.jl 100% <0%> (+22.22%) :arrow_up:
src/boykov_kolmogorov.jl 100% <0%> (+31.7%) :arrow_up:
src/edmonds_karp.jl 100% <0%> (+36.5%) :arrow_up:
src/dinic.jl 100% <0%> (+43.18%) :arrow_up:
src/mincost.jl 100% <0%> (+50%) :arrow_up:
src/push_relabel.jl 100% <0%> (+55.93%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 016dfd5...b0d1846. Read the comment docs.

matbesancon commented 4 years ago

Could you add a test corresponding to the bug observed in #27 ?

coveralls commented 4 years ago

Coverage Status

Coverage increased (+32.6%) to 98.258% when pulling b0d184664208bea1a6f8c4631152ff6b3e42bbcd on etienneINSA:mincut into 016dfd5c1b3bb7c77b94dbfd30046bc806832e8f on JuliaGraphs:master.