JuliaGraphs / StaticGraphs.jl

Memory-efficient immutable LightGraphs.
Other
33 stars 8 forks source link

Cleanup #4

Closed matbesancon closed 6 years ago

matbesancon commented 6 years ago

Fixed https://github.com/JuliaGraphs/StaticGraphs.jl/issues/1 for static graphs and digraphs, introduced in(::StaticEdge ::StaticGraph) instead of has_edge

codecov[bot] commented 6 years ago

Codecov Report

Merging #4 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   98.85%   98.82%   -0.03%     
==========================================
  Files           5        5              
  Lines          87       85       -2     
==========================================
- Hits           86       84       -2     
  Misses          1        1
Impacted Files Coverage Δ
src/utils.jl 75% <ø> (ø) :arrow_up:
src/StaticGraphs.jl 100% <100%> (ø) :arrow_up:
src/staticgraph.jl 100% <100%> (ø) :arrow_up:
src/staticdigraph.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19c3d81...3bb8dae. Read the comment docs.

matbesancon commented 6 years ago

Last commits also tackles https://github.com/JuliaGraphs/StaticGraphs.jl/issues/5 as discussed

sbromberger commented 6 years ago

Oh, man, @matbesancon - I messed up this open PR. Sorry. Would you mind cherry-picking what still needs to be included?

matbesancon commented 6 years ago

I'll check it this week, anyway this may need updates after 1.0

On Sun, Aug 12, 2018, 01:15 Seth Bromberger notifications@github.com wrote:

Oh, man, @matbesancon https://github.com/matbesancon - I messed up this open PR. Sorry. Would you mind cherry-picking what still needs to be included?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaGraphs/StaticGraphs.jl/pull/4#issuecomment-412309792, or mute the thread https://github.com/notifications/unsubscribe-auth/AHRRsi3INU9aA5aIc8n68RiA5_M1DaXwks5uP3O4gaJpZM4R336q .

matbesancon commented 6 years ago

Also fixes #5