search

JuliaGraphs / juliagraphs.github.io

Organization page
https://juliagraphs.org
7 stars 8 forks source link

migrating to franklin #18

Closed tlienart closed 3 years ago

tlienart commented 3 years ago

closes #17

Note: I didn't try to solve #11 , just migrated the content as it is now.

preview: https://tlienart.github.io/juliagraphs.github.io/

Note: there's a difference in the font; not sure why that is; probably not very important.

ViralBShah commented 3 years ago

Is it necessary to commit all these files into the source? I mean the fonts and such.

Just asking in case they are auto-generated and/or accidentally checked in.

tlienart commented 3 years ago

if you never intend to use KaTeX we can remove that which is most of the files.

ViralBShah commented 3 years ago

I suppose it can be added back if necessary - but seems like a pretty plain site to me otherwise.

ViralBShah commented 3 years ago

Would it be easy to simplify the page design a bit to remove the two column layout? Or is that a lot of CSS work and not worth doing?

tlienart commented 3 years ago

alright I trimmed to the essentials :)

ViralBShah commented 3 years ago

Thanks! Is it possible to preview? Or I can just go for the merge and fix it as we go along...

tlienart commented 3 years ago

for the preview, yes, though the prepath will need to be removed before the merge.

(will post here when the preview is generated)

tlienart commented 3 years ago

Preview: https://tlienart.github.io/juliagraphs.github.io/

(before merging, remove the line prepath=... in the config.md)

ViralBShah commented 3 years ago

This seems to visually look the same as what we had before, right? Is it just a simplification of the underlying code?

tlienart commented 3 years ago

it's identical to what was there before, the only visible change is that the font is not identical (I'm not sure why).

If you compare the HTML of https://tlienart.github.io/juliagraphs.github.io/ and https://juliagraphs.org you'll see that it's basically identical

ViralBShah commented 3 years ago

Ok - can you delete the prepath? I'll have to make a PR to your PR otherwise. Let's merge.

tlienart commented 3 years ago

yep done

tlienart commented 3 years ago

nice: https://juliagraphs.org :+1:

ViralBShah commented 3 years ago

So after this PR, in the github pages settings, I am unable to set the CNAME to juliagraphs.org. It claims the name is taken, and as a result none of the other docs links on the packages are working.

I manually pushed a CNAME file to this repo, but that doesn't seem to help. For example, the Graphs.jl docs link doesn't work now. I am a bit confused that juliagraphs.org actually works.

It says "The custom domain juliagraphs.org is already taken", but I wonder which repo is claiming it.