search

JuliaHCI / HCIToolbox.jl

Common utilities for high-contrast imaging
https://juliahci.github.io/HCIToolbox.jl/dev/
MIT License
3 stars 2 forks source link

Cube Generator #33

Closed mileslucas closed 3 years ago

mileslucas commented 3 years ago

This updates the PSF injection, creating the useful CubeGenerator struct which helps bootstrap the process of creating many synthetic data cubes, such as for MLE.

This also removes the Kernels module in lieu of PSFModels.jl. No deprecations, but I have updated the semvar to indicate a breaking change.

An important change, too, is to use tuple/Polar instead of the keyword arguments for injecting. This generally simplifies the code, and when my Polard PR gets merged it will be even more usable.

codecov[bot] commented 3 years ago

Codecov Report

Merging #33 (621ea29) into master (234c183) will decrease coverage by 4.66%. The diff coverage is 73.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   86.36%   81.69%   -4.67%     
==========================================
  Files           9        9              
  Lines         374      306      -68     
==========================================
- Hits          323      250      -73     
- Misses         51       56       +5
Flag Coverage Δ
unittests 81.69% <73.84%> (-4.67%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HCIToolbox.jl 100.00% <ø> (ø)
src/inject.jl 70.83% <73.84%> (-16.04%) :arrow_down:
src/masking.jl 43.58% <0.00%> (-2.93%) :arrow_down:
src/geometry/multiannulus.jl 86.27% <0.00%> (-1.03%) :arrow_down:
src/scaling.jl 95.12% <0.00%> (-0.80%) :arrow_down:
src/geometry/annulus.jl 84.00% <0.00%> (-0.38%) :arrow_down:
src/angles.jl 100.00% <0.00%> (ø)
src/morphology.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 234c183...f60d715. Read the comment docs.