codecov[bot]
commented
1 year ago Codecov Report
Merging #15 (df3cc52) into main (5349c3c) will not change coverage. The diff coverage is
100.00%.:exclamation: Current head df3cc52 differs from pull request most recent head 3e55259. Consider uploading reports for the commit 3e55259 to get more accurate results
@@ Coverage Diff @@
## main #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 70 71 +1
=========================================
+ Hits 70 71 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/SubpixelRegistration.jl | 100.00% <100.00%> (ø) |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
fixes #12
~in the future I may add a keyword argument to do phase normalization, but~ for now I've just switched the default to no normalization. This matches the Guizar-Sicairos reference implementation in matlab. Also, according to the scikit-image docs skipping normalization should be better for noisy data, which is my primary use case for astronomical imaging.
~I did try with a flag for normalization, but for some reason the tests started failing and I don't quite feel like digging into why.~
There is now an optional flag for phase normalization with appropriate tests.