search

JuliaHEP / AwkwardArray.jl

Awkward Array in Julia mirrors the Python library, enabling effortless zero-copy data exchange between Julia and Python
https://juliahep.github.io/AwkwardArray.jl/dev/
MIT License
31 stars 2 forks source link

feat: add content types #62

Closed ianna closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.29%. Comparing base (d11e61d) to head (6769ac1). Report is 7 commits behind head on main.

Files Patch % Lines
src/all_implementations.jl 95.45% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #62 +/- ## ========================================== + Coverage 74.06% 75.29% +1.22% ========================================== Files 4 4 Lines 1666 1623 -43 ========================================== - Hits 1234 1222 -12 + Misses 432 401 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Moelf commented 7 months ago

sorry I should have left a comment earlier. I wonder if this is the best way to go about it. I suppose this is a way to fix things, I don't know the performance implication.

An alternative way is to fix: https://github.com/JuliaHEP/AwkwardArray.jl/blob/d11e61d71f5833c43b722c70e07bc13df09fd5c1/src/all_implementations.jl#L101

by adding one more parametric type into it, so that it can be properly <:AbstractArray{T, 1}?

ianna commented 7 months ago

@Moelf - Do you know how stable Julia's nightly builds are? We get an Unreachable reached while iterating on a Vector of a Union with Missing and calling a layout_for its elements: 

AwkwardArray.from_iter(
  Vector{Union{Missing,Float64,Vector{Int64}}}([1.1, [1, 2], missing, [3]]),
)
Moelf commented 7 months ago

yeah looking into it right now, I opened #66