JuliaHEP / AwkwardArray.jl

Awkward Array in Julia mirrors the Python library, enabling effortless zero-copy data exchange between Julia and Python
https://juliahep.github.io/AwkwardArray.jl/dev/
MIT License
31 stars 2 forks source link

Audit the `unsafe` call #68

Open Moelf opened 7 months ago

Moelf commented 7 months ago

https://github.com/JuliaHEP/AwkwardArray.jl/blob/095a48b49200b1d4e3288192d5eda1a189638fcf/src/all_implementations.jl#L3462-L3465

we should try to remove this unsafe call because Julia's built-in Vector now has an underlying Memory{T} construct that may interfere with pointer hacks