search

JuliaHEP / Geant4.jl

Julia bindings to the Geant4 simulation toolkit
https://juliahep.github.io/Geant4.jl/stable/
Apache License 2.0
32 stars 5 forks source link

Update `G4Hist` to changes in `FHist@0.11` #14

Closed fhagemann closed 2 months ago

fhagemann commented 2 months ago

There were some breaking syntax changes in FHist@0.11 that require Geant4.jl to be fixed to FHist@0.10. This results in the fact, that Geant4 is downgraded to the version v0.1.13 when FHist is upgraded to v0.11.

In this PR, I tried to update the code to the breaking changes in FHist@0.11.

The tests will fail because the G4Examples are also partly written in the old FHist syntax. I will also open a PR to G4Examples where these breaking changes are fixed.

fhagemann commented 2 months ago

The PR to G4Examples can be found here: https://github.com/JuliaHEP/G4Examples.jl/pull/2

fhagemann commented 2 months ago

The tests seem to pass now with the updated G4Examples !

However, Geant4.jl might need a new minor release (0.1.17?) and the [compat] in G4Examples might need to be updated to that new version to not clash with incompatible Geant4@0.1.16 and FHist@0.11. Let me know if I can do anything to help.

peremato commented 2 months ago

Yes, you are right. I'll make a minor release.

peremato commented 2 months ago

Thanks for the changes!

fhagemann commented 2 months ago

Yes, you are right. I'll make a minor release.

Thanks!