search

JuliaHEP / Geant4.jl

Julia bindings to the Geant4 simulation toolkit
https://juliahep.github.io/Geant4.jl/stable/
Apache License 2.0
32 stars 5 forks source link

Version tags #2

Closed oschulz closed 1 year ago

oschulz commented 1 year ago

@peremato , when this package gets registered, Julia Registrator won't like the fact that it's already at version 0.1.2.

I would suggest to revert to version 0.1.0, if possible, until package registration.

CC @moelf

peremato commented 1 year ago

I increased the version number on my failed attempts to register. It required Geant4_julia_jll be registered and some issue with the compat section. According to the mail I got I should re-attempt without changing the version.

oschulz commented 1 year ago

I increased the version number on my failed attempts to register.

Yes, you don't need to increase the version number to re-try registering, you can just comment <@-sign>JuliaRegistrator register on a different commit to re-trigger registration. Also, ideally, don't create the tags/releases by hand, but use the Julia TagBot, it'll create the tags and releases for you. That will ensure that the tags/releases on the repo match the package versions in the Registry.

JuliaRegistrator commented 1 year ago

Error while trying to register: Register Failed @oschulz, it looks like you don't have collaborator status on this repository.

peremato commented 1 year ago

@oschulz Before re-trying the registration I need to sort out the problem https://github.com/JuliaRegistries/General/pull/80960#issuecomment-1495267235 registering Geant4_julia_jll I have asked Mosè Giordano, but perhaps you have an idea. https://github.com/JuliaPackaging/Yggdrasil/pull/6490#issuecomment-1495388772

oschulz commented 1 year ago

Regarding the name "geant4_julia_jll",

write a comment like

[noblock]

Regarding "Lowercase package name geant4_julia_jll contains the string julia"  - I tried to follow naming conventions for similar packages in Yggdrasil". Could this be merged manually?

on https://github.com/JuliaRegistries/General/pull/80960 .

But like you say, the package loading problem needs to be figured out first. @giordano is the expert here ... Mosè, do you see what's going wrong there?

giordano commented 1 year ago

I answered at https://github.com/JuliaPackaging/Yggdrasil/pull/6490#issuecomment-1495715943

peremato commented 1 year ago

The registration did work successfully.

oschulz commented 1 year ago

Congrats!

oschulz commented 1 year ago

I suggest you add Julia TagBot to your GitHub actions, @peremato , it'll automatically created releases on the repo after Registrator is done with it's job.

oschulz commented 1 year ago

I also very highly recommend to add https://github.com/JuliaRegistries/CompatHelper.jl as a GitHub action.