Closed aoanla closed 10 months ago
PR Preview Action v1.4.4
:---:
:rocket: Deployed preview to https://JuliaHEP.github.io/JuliaHEP-2023/pr-preview/pr-21/
on branch gh-pages
at 2023-11-04 09:43 UTC
Hm, all good except apparently jupyterbook really does not like the output of the unicodeplots backend!
yeah if we're rendering notebook we might as well do real plots
I mean, it is a real plot - it's just the most fun alternative backend to use to show that you can switch (except apparently when the book renderer has a fit over terminal control codes)
On Fri, 3 Nov 2023, 21:20 Jerry Ling, @.***> wrote:
yeah if we're rendering notebook we might as well do real plots
— Reply to this email directly, view it on GitHub https://github.com/JuliaHEP/JuliaHEP-2023/pull/21#issuecomment-1793118499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNRWLIZCM43VQ6G2GW5WITYCVN3PAVCNFSM6AAAAAA644HVA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGEYTQNBZHE . You are receiving this because you authored the thread.Message ID: @.***>
I do agree that UncodePlots are great - I love them for little fast things in the REPL or CLI, so it's a shame it doesn't work here.
@aoanla - I guess you need to rebase now, after the DataFrame merge
I think my only additional suggestion here is that you add some L2 headers, so that the page can be more easily navigated from the RHS TOC
Absolutely, I will rebase on the current main & add more headers in the morning.
On Fri, 3 Nov 2023, 22:51 Graeme A Stewart, @.***> wrote:
I think my only additional suggestion here is that you add some L2 headers, so that the page can be more easily navigated from the RHS TOC
— Reply to this email directly, view it on GitHub https://github.com/JuliaHEP/JuliaHEP-2023/pull/21#issuecomment-1793212125, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNRWLM73S52DTJAEIP2MBLYCVYQPAVCNFSM6AAAAAA644HVA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGIYTEMJSGU . You are receiving this because you were mentioned.Message ID: @.***>
Things I really hate, doing a rebase on something with a Manifest in it
Looks good to me - as "Alternatives: Makie.jl" is a L1 header it appears in the LHS menu, but I think this is ok as you can teach all the plotting stuff from the one notebook.
This is the same stuff as #20 but from a local branch to check it does build with the integrations