search

JuliaHEP / JuliaHEP-2023

Materials for the JuliaHEP 2023 Workshop
https://juliahep.github.io/JuliaHEP-2023/
Creative Commons Attribution 4.0 International
4 stars 4 forks source link

"Merged version of Graeme's syntax branch and my equivalent branch" #8

Closed aoanla closed 10 months ago

aoanla commented 10 months ago

This is mostly Graeme's stuff with additional things from my branch interpolated (like a bit on arrays in the types notebook, a brief mention of string interpolation, etc).

aoanla commented 10 months ago
  • A failing cell that needs the raises-exception property
  • Repetition of InexactError example
  • Rational type shown/explained in two places
  • Some of the basic function documentation is now repeated.

However, I think we should merge this now and smooth off the rough bits in some follow-up commits.

Hm, I thought I'd removed most of the repetition of functions (maybe I got confused when making this merge) - to be clear, I think we should remove the basic function stuff from the top of the "multiple dispatch" page, which I thought I'd done? Unless the repetition is elsewhere?

graeme-a-stewart commented 10 months ago

The diffs are very unhelpful with all the notebook metadata (OTOH, having cell output makes browsing on GitHub much more useful), so maybe things were missed?

AFAICS the basic and compact function definitions are being repeated, as well as the lambda construction. (Although quick repetition is not without value in teaching material.)

I can tidy up a few things after lunch, unless you want the editing token, @aoanla?

aoanla commented 10 months ago

I can try to fix before lunch - I will take the token and note here when I return t

On Mon, 23 Oct 2023, 11:01 Graeme A Stewart, @.***> wrote:

The diffs are very unhelpful with all the notebook metadata (OTOH, having cell output makes browsing on GitHub much more useful), so maybe things were missed?

AFAICS the basic and compact function definitions are being repeated, as well as the lambda construction. (Although quick repetition is not without value in teaching material.)

I can tidy up a few things after lunch, unless you want the editing token, @aoanla https://github.com/aoanla?

— Reply to this email directly, view it on GitHub https://github.com/JuliaHEP/JuliaHEP-2023/pull/8#issuecomment-1774842831, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNRWLINXDXRE3FJGFQ7EP3YAY56TAVCNFSM6AAAAAA6KH3AM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHA2DEOBTGE . You are receiving this because you were mentioned.Message ID: @.***>

aoanla commented 10 months ago

So, on the "InexactError" example - your version - UInt(i^4)

...doesn't throw an error for me (it just silently overflows and loops around). I wasn't sure if this was on me, my copy of Julia or what, so I've left in that and the version of it that I have that leads on after the "fixed-type variables" demo.

aoanla commented 10 months ago

Okay, new PR should resolve most of the issues

On Mon, 23 Oct 2023 at 11:18, Sam Skipsey @.***> wrote:

I can try to fix before lunch - I will take the token and note here when I return t

On Mon, 23 Oct 2023, 11:01 Graeme A Stewart, @.***> wrote:

The diffs are very unhelpful with all the notebook metadata (OTOH, having cell output makes browsing on GitHub much more useful), so maybe things were missed?

AFAICS the basic and compact function definitions are being repeated, as well as the lambda construction. (Although quick repetition is not without value in teaching material.)

I can tidy up a few things after lunch, unless you want the editing token, @aoanla https://github.com/aoanla?

— Reply to this email directly, view it on GitHub https://github.com/JuliaHEP/JuliaHEP-2023/pull/8#issuecomment-1774842831, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNRWLINXDXRE3FJGFQ7EP3YAY56TAVCNFSM6AAAAAA6KH3AM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHA2DEOBTGE . You are receiving this because you were mentioned.Message ID: @.***>

-- Sam Skipsey (he/him, they/them)

graeme-a-stewart commented 10 months ago

So, on the "InexactError" example - your version - UInt(i^4)

...doesn't throw an error for me (it just silently overflows and loops around). I wasn't sure if this was on me, my copy of Julia or what, so I've left in that and the version of it that I have that leads on after the "fixed-type variables" demo.

I also noticed - I'll fix it in my next PR!