search

JuliaHEP / UnROOT.jl

Native Julia I/O package to work with CERN ROOT files objects (TTree and RNTuple)
https://juliahep.github.io/UnROOT.jl/
MIT License
102 stars 17 forks source link

Add support for more primitive (vector/jagged) leaf types #299

Closed tamasgal closed 10 months ago

tamasgal commented 10 months ago

Just a small PR which adds several vector/jagged primitive support for leaf types. This is a quick fix for https://github.com/JuliaHEP/UnROOT.jl/issues/298

codecov[bot] commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d0628a9) 87.83% compared to head (584697b) 87.44%.

:exclamation: Current head 584697b differs from pull request most recent head 11fa061. Consider uploading reports for the commit 11fa061 to get more accurate results

Files Patch % Lines
src/root.jl 62.50% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #299 +/- ## ========================================== - Coverage 87.83% 87.44% -0.40% ========================================== Files 18 18 Lines 2376 2389 +13 ========================================== + Hits 2087 2089 +2 - Misses 289 300 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tamasgal commented 10 months ago

The reason for the incomplete coverage is the fact that I wanted to utilise some metaprogramming features to make it a bit more elegant and support all primitives... maybe this PR should be extended to cover them finally 🙈

tamasgal commented 10 months ago

I added a few more...