search

JuliaHEP / UnROOT.jl

Native Julia I/O package to work with CERN ROOT files objects (TTree and RNTuple)
https://juliahep.github.io/UnROOT.jl/
MIT License
102 stars 17 forks source link

Remove nightly Julia build from CI #302

Closed tamasgal closed 8 months ago

tamasgal commented 9 months ago

The nightly build is often broken and the CI badge shows "failing" because it picks that up. I don't think we need to waste resources on the nightly Julia CI anyways.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (77b75d8) 87.44% compared to head (9f221c9) 87.02%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #302 +/- ## ========================================== - Coverage 87.44% 87.02% -0.43% ========================================== Files 18 18 Lines 2389 2404 +15 ========================================== + Hits 2089 2092 +3 - Misses 300 312 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Moelf commented 9 months ago

image

CI badge doesn't show nightly fail; Revise also does what we do now: https://github.com/timholy/Revise.jl/pull/799

tamasgal commented 9 months ago

Currently not, but it shows it from time to time ;)

tamasgal commented 9 months ago

Here is a short discussion: https://discourse.julialang.org/t/ignoring-nightly-failure-for-ci-badge/98028

But I am not sure if we really need nightly CI of Julia at all. I have not found the results of that job helpful at all. I always ignore that ;)

Moelf commented 9 months ago

I kinda need it so that when new release come around it's not broken