search

JuliaHEP / UnROOT.jl

Native Julia I/O package to work with CERN ROOT files objects (TTree and RNTuple)
https://juliahep.github.io/UnROOT.jl/
MIT License
102 stars 17 forks source link

add promote_rule for Index64 #322

Closed Moelf closed 7 months ago

Moelf commented 7 months ago

fix #321

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.75%. Comparing base (08eb84c) to head (d240f26).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #322 +/- ## ========================================== + Coverage 85.74% 85.75% +0.01% ========================================== Files 18 19 +1 Lines 2490 2492 +2 ========================================== + Hits 2135 2137 +2 Misses 355 355 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

peremato commented 7 months ago

Thanks @Moelf. I works nicely!

peremato commented 7 months ago

Would it be possible to make a new release such that I can release what I have which depends on UnROOT?

Moelf commented 7 months ago

@peremato feel free to do it if you have time. I personally would try to understand if using Index64 is bad to begin with or what... but we can always fix bugs later

Moelf commented 7 months ago

ok merging this because typemax(Int64) bits is more than 1 EB