JuliaHEP / UnROOT.jl

Native Julia I/O package to work with CERN ROOT files objects (TTree and RNTuple)
https://juliahep.github.io/UnROOT.jl/
MIT License
97 stars 17 forks source link

CompatHelper: bump compat for FHist to 0.11, (keep existing compat) #325

Closed github-actions[bot] closed 5 months ago

github-actions[bot] commented 5 months ago

This pull request changes the compat entry for the FHist package from ^0.10 to ^0.10, 0.11. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

Moelf commented 5 months ago

Yeah don't do this I need to test it first

tamasgal commented 5 months ago

Do we want to ditch FHist 0.10 support? My workflows are now broken, I adopted FHist 0.11 too early 😆

Moelf commented 5 months ago

I think we can support both -- technically only the constructor is broken in FHist.jl v0.11, so as long as we return the histograms from UnROOT.jl it should be fine?

tamasgal commented 5 months ago

You mean checking the version of FHist.jl and use the corresponding constructor?

Moelf commented 5 months ago

Yes