search

JuliaHEP / UpROOT.jl

Julia package to access CERN ROOT files, wraps Python package uproot
Other
15 stars 3 forks source link

More tests! #18

Closed gipert closed 3 years ago

gipert commented 3 years ago

Maybe we should test also variable binned hists...

gipert commented 3 years ago

^ @oschulz can you approve GitHub actions for me?

codecov[bot] commented 3 years ago

Codecov Report

Merging #18 (fc54ded) into hists (c80e0e5) will increase coverage by 7.44%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            hists      #18      +/-   ##
==========================================
+ Coverage   36.27%   43.72%   +7.44%     
==========================================
  Files           8        8              
  Lines         215      215              
==========================================
+ Hits           78       94      +16     
+ Misses        137      121      -16
Impacted Files Coverage Δ
src/testdata.jl 100.00% <ø> (ø)
src/pyjlconv.jl 70.00% <100.00%> (+23.33%) :arrow_up:
src/ttree.jl 48.00% <0.00%> (+1.33%) :arrow_up:
src/tdirectory.jl 87.50% <0.00%> (+12.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c80e0e5...fc54ded. Read the comment docs.

gipert commented 3 years ago

Ha! how do we get around this?

https://docs.julialang.org/en/v1/base/base/#Base.hasproperty

gipert commented 3 years ago

@oschulz can you merge this, if it's ok for you?

oschulz commented 3 years ago

can you approve GitHub actions for me

Sure - do you know what repo permissions are required for that?

oschulz commented 3 years ago

Thanks for this!

giordano commented 3 years ago

do you know what repo permissions are required for that?

Now GitHub Actions don't run automatically for first-time contributors, every time they push to a pull request someone needs to click on the "approve" button. I've been doing that the whole day :wink:

oschulz commented 3 years ago

Now GitHub Actions don't run automatically for first-time contributors

Arggggh :-)