search

JuliaHealth / DICOM.jl

Julia package for reading and writing DICOM (Digital Imaging and Communications in Medicine) files
MIT License
56 stars 21 forks source link

fixes for reading and writing some sequences #45

Closed vsaase closed 4 years ago

vsaase commented 4 years ago

hi, this fixes reading sequences that contain pixel data and therefore need the other values contained in the sequence dict, for example IconImageSequence also fixes writing some sequences also adds some dicom tags

codecov[bot] commented 4 years ago

Codecov Report

Merging #45 into master will decrease coverage by 0.59%. The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #45     +/-   ##
=========================================
- Coverage   88.55%   87.95%   -0.6%     
=========================================
  Files           1        1             
  Lines         297      299      +2     
=========================================
  Hits          263      263             
- Misses         34       36      +2
Impacted Files Coverage Δ
src/DICOM.jl 87.95% <40%> (-0.6%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35547d7...59135a3. Read the comment docs.

notZaki commented 4 years ago

Looks good to me. Thanks!