JuliaHealth / DICOM.jl

Julia package for reading and writing DICOM (Digital Imaging and Communications in Medicine) files
MIT License
56 stars 21 forks source link

Remove Julia 1.3 from Travis CI configuration #58

Closed notZaki closed 4 years ago

notZaki commented 4 years ago

Julia 1.3 doesn't need to be in the tests. It was added when Julia 1.3 was the latest version and I didn't know that the version '1' would always use the latest release.

codecov[bot] commented 4 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files           1        1           
  Lines         312      312           
=======================================
  Hits          274      274           
  Misses         38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd50f23...9db16da. Read the comment docs.

notZaki commented 4 years ago

A more aggressive approach could be to remove the latest release, i.e. '1', from the tests as well. In theory, the builds on 1.0 and nightly should encompass everything in between.

DilumAluthge commented 4 years ago

A more aggressive approach could be to remove the latest release, i.e. '1', from the tests as well. In theory, the builds on 1.0 and nightly should encompass everything in between.

In theory.... sometimes nightly does weird stuff though.

DilumAluthge commented 4 years ago

One thing we could consider would be switching from Travis to GitHub Actions. Usually GH Actions is much faster.

If you're interested, let me know - I'm happy to make a PR to set up GH Actions for CI testing on this repo.

notZaki commented 4 years ago

That sounds great! I'm curious about GH Actions too, so seeing it applied in a setup I'm previously familiar with would be a useful learning opportunity for me.