search

JuliaHealth / DICOM.jl

Julia package for reading and writing DICOM (Digital Imaging and Communications in Medicine) files
MIT License
56 stars 21 forks source link

Return compressed bytes instead of an EOFError #71

Closed notZaki closed 3 years ago

notZaki commented 3 years ago

An EOFError is thrown while reading pixel data if the DICOM image is compressed (#33, #69) This PR fixes that by parsing the compressed bytes. However, the actual image is still not returned---this would probably require using an external library for decompressing the bytes.

An unrelated change is that the DICOMData type now contains the parsed VRs. This will simplify the parsing/writing functions in the future.

codecov[bot] commented 3 years ago

Codecov Report

Merging #71 (168b741) into master (d345ccb) will increase coverage by 3.11%. The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   89.78%   92.89%   +3.11%     
==========================================
  Files           2        2              
  Lines         372      366       -6     
==========================================
+ Hits          334      340       +6     
+ Misses         38       26      -12
Impacted Files Coverage Δ
src/DICOMData.jl 100.00% <ø> (ø)
src/DICOM.jl 92.44% <96.29%> (+3.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d345ccb...168b741. Read the comment docs.