search

JuliaHealth / DICOM.jl

Julia package for reading and writing DICOM (Digital Imaging and Communications in Medicine) files
MIT License
56 stars 21 forks source link

nested sequence item parsing to fix issue with IconImageSequence #80

Closed vsaase closed 3 years ago

vsaase commented 3 years ago

When parsing a DICOM file with IconImageSequence, the parser stumbles over the PixelData inside the sequence, because of calling pixeldata_parse with the root DICOMData as an argument. Using the item as the DICOMData argument in reading the items elements solves this.

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (2a41e50) into master (155ccec) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   92.59%   92.57%   -0.02%     
==========================================
  Files           2        2              
  Lines         378      377       -1     
==========================================
- Hits          350      349       -1     
  Misses         28       28
Impacted Files Coverage Δ
src/DICOM.jl 91.93% <100.00%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 155ccec...2a41e50. Read the comment docs.

notZaki commented 3 years ago

LGTM! Thanks for fixing this.