Code refactoring and efficiency

JuliaHealth / KomaMRI.jl

Koma is a Pulseq-compatible framework to efficiently simulate Magnetic Resonance Imaging (MRI) acquisitions. The main focus of this package is to simulate general scenarios that could arise in pulse sequence development.

https://JuliaHealth.github.io/KomaMRI.jl/dev/

MIT License

111 stars 19 forks source link

Code refactoring and efficiency #63

Open cncastillo opened 2 years ago

cncastillo commented 2 years ago

As it is right now, each call of the SimulationCore's functions allocates the objects in GPU memory.

Changing the functions to use AbstractArrays and allocate GPU memory one time in simulate should be the way to go.

[x] Change functions to use AbstractArrays
[x] #116
[x] #119
[ ] #126 Improve type stability (Looking at this could be helpful as well)
[x] #120
[ ] #121

cncastillo commented 2 years ago

A performance test should be done using NVIDIA Nsight Systems (Tutorial: https://www.youtube.com/watch?v=jqBHgix42AI)