JuliaHealth / OMOPCDMCohortCreator.jl

Create cohorts from databases utilizing the OMOP CDM
https://juliahealth.org/OMOPCDMCohortCreator.jl/stable
Other
8 stars 7 forks source link

Adding the column name #43

Closed Farreeda closed 1 year ago

Farreeda commented 1 year ago

For issue #42

TheCedarPrince commented 1 year ago

@VarshC , could you review this PR and ping me when done? This is to address issue #42 for context. Thanks!

TheCedarPrince commented 1 year ago

Hey @Farreeda , thanks for this! Just had a moment to review the PR. For the following section:


### Task: Find All Patients with Strep Throat

Using the [API](@ref), find all patients with strep throat.

Suggested solution:

```julia

### Task: Find All Patients with Strep Throat

Using the [API](@ref), find all patients with strep throat.

Suggested solution:

```julia
strep_patients = occ.ConditionFilterPersonIDs(28060, conn)

Task: Find the Race of Patients with Strep Throat

For the patients who have strep throat diagnoses, find their race.

Suggested solution:

strep_patients_race = occ.GetPatientRace(strep_patients.person_id, conn)

Task: Find the Gender of Patients with Strep Throat

For the patients who have strep throat diagnoses, find their gender.

Suggested solution:

strep_patients_gender = occ.GetPatientGender(strep_patients.person_id, conn)

Instead of switching references of `strep_patients` to `strep_patients.person_id`, let's instead switch the line: `strep_patients = occ.ConditionFilterPersonIDs(28060, conn)`

To

```julia
strep_patients = occ.ConditionFilterPersonIDs(28060, conn).person_id

Then let's merge the PR!

P.S. Also, thanks for a light review earlier @VarshC !

TheCedarPrince commented 1 year ago

@Farreeda -- thanks for contributing!