JuliaHealth / OMOPCDMCohortCreator.jl

Create cohorts from databases utilizing the OMOP CDM
https://juliahealth.org/OMOPCDMCohortCreator.jl/stable
Other
9 stars 7 forks source link

Resolving `ExecuteAudit` function getting Breaked Easily #60

Closed Jay-sanjay closed 11 months ago

Jay-sanjay commented 11 months ago

fixing #48

codecov[bot] commented 11 months ago

Codecov Report

Merging #60 (688cf87) into dev (77126d0) will increase coverage by 0.45%. Report is 71 commits behind head on dev. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev      #60      +/-   ##
==========================================
+ Coverage   73.36%   73.81%   +0.45%     
==========================================
  Files           6        6              
  Lines         199      275      +76     
==========================================
+ Hits          146      203      +57     
- Misses         53       72      +19     
Files Coverage Δ
src/executors.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

TheCedarPrince commented 11 months ago

Hey @Jay-sanjay ! Thanks for working on this! The functionality looks perfect -- could you just add in one test testing the auditing of a DataFrame by passing a value to the kwarg? Once you add the test, this should be set for merging! :smile: Great work!

Jay-sanjay commented 11 months ago

Thanks !! again