JuliaHealth / OMOPCDMCohortCreator.jl

Create cohorts from databases utilizing the OMOP CDM
https://juliahealth.org/OMOPCDMCohortCreator.jl/stable
Other
8 stars 7 forks source link

Added GetDrugExposureStartDate Function #70

Closed nitverse closed 5 months ago

nitverse commented 5 months ago

Added the function getDrugExposureStartDate as mentioned in the issue #68

codecov[bot] commented 5 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ac5bcf0) 74.51% compared to head (54c4504) 73.33%.

Files Patch % Lines
src/getters.jl 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #70 +/- ## ========================================== - Coverage 74.51% 73.33% -1.19% ========================================== Files 6 6 Lines 310 315 +5 ========================================== Hits 231 231 - Misses 79 84 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TheCedarPrince commented 5 months ago

Hi @nitverse,

Thanks for giving this a try! There's still a fair amount of work to do on this as of now, but happy to work with you through it! Here's what else needs to be done:

Thankfully, we've enumerated this procedure in a pretty straightforward manner and would suggest looking at the code example here: https://github.com/JuliaHealth/OMOPCDMCohortCreator.jl/blob/ac5bcf02a67ff0afe7868c6d77b61674daa2795e/src/getters.jl#L1485 and referring to the PR I mentioned in the original issue.

Let me know if you have any questions!

TheCedarPrince commented 5 months ago

Hey @nitverse -- were you going to work more on this PR?

Jay-sanjay commented 5 months ago

This is fixed by #72