JuliaHealth / OMOPCDMCohortCreator.jl

Create cohorts from databases utilizing the OMOP CDM
https://juliahealth.org/OMOPCDMCohortCreator.jl/stable
Other
8 stars 7 forks source link

Added GetDrugExposureEndDate function #71

Closed Jay-sanjay closed 5 months ago

Jay-sanjay commented 5 months ago

This PR is related to #69

PR CheckList

closes #69

codecov[bot] commented 5 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac5bcf0) 74.51% compared to head (7edede7) 74.37%.

Files Patch % Lines
src/getters.jl 70.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================== - Coverage 74.51% 74.37% -0.15% ========================================== Files 6 6 Lines 310 320 +10 ========================================== + Hits 231 238 +7 - Misses 79 82 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jay-sanjay commented 5 months ago

@TheCedarPrince yes that might be a good idea,I can file an issue for it. Because if in case I won't able to add that for all function, then also the issue would be present for the future work.

That said thanks for the review, it means a lot to me