search

JuliaHealth / OMOPCDMCohortCreator.jl

Create cohorts from databases utilizing the OMOP CDM
https://juliahealth.org/OMOPCDMCohortCreator.jl/stable
Other
8 stars 7 forks source link

Added GetDrugExposureStartDate function #72

Closed Jay-sanjay closed 5 months ago

Jay-sanjay commented 5 months ago

This PR is related to #68

PR CheckList

closes #68

codecov[bot] commented 5 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (15b8500) 74.37% compared to head (fe7cd4a) 74.24%.

Files Patch % Lines
src/getters.jl 70.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #72 +/- ## ========================================== - Coverage 74.37% 74.24% -0.14% ========================================== Files 6 6 Lines 320 330 +10 ========================================== + Hits 238 245 +7 - Misses 82 85 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TheCedarPrince commented 5 months ago

Hey @Jay-sanjay , could you remind me, what is keeping this PR from being merged? Do you need me to do something?

Jay-sanjay commented 5 months ago

@TheCedarPrince One thing before I merge this PR, I see if here we want to add regarding writing sql returning in the doc-string here https://github.com/JuliaHealth/OMOPCDMCohortCreator.jl/blob/15b850008dc92c091e58695f34791d58dd607a84/src/getters.jl#L1956 then I guess we need to update the the doc-string of almost all getters functions like - https://github.com/JuliaHealth/OMOPCDMCohortCreator.jl/blob/ac5bcf02a67ff0afe7868c6d77b61674daa2795e/src/getters.jl#L1550Am I pointing correctly, or did I do a mistake

TheCedarPrince commented 5 months ago

I see what you mean. I am going to say, let's merge this now and create another separate documentation PR that fixes this across all functions. In theory, it should be a kinda fast grep and replace...