search

JuliaHealth / OMOPCDMCohortCreator.jl

Create cohorts from databases utilizing the OMOP CDM
https://juliahealth.org/OMOPCDMCohortCreator.jl/stable
Other
8 stars 7 forks source link

Added a better Default for GetPatientAgeGroup #75

Closed Jay-sanjay closed 4 months ago

Jay-sanjay commented 4 months ago

This PR addresses #73

closes #73

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ac5bcf0) 74.51% compared to head (fb9cfd8) 74.51%. Report is 75 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #75 +/- ## ======================================= Coverage 74.51% 74.51% ======================================= Files 6 6 Lines 310 310 ======================================= Hits 231 231 Misses 79 79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TheCedarPrince commented 4 months ago

So, for some reason, this is now failing on nightly. I am fairly certain this is a result of something happening in nightly and may end up submitting a bug to Julia itself. Otherwise, I am going to accept this PR. Thanks @Jay-sanjay

TheCedarPrince commented 4 months ago

@Jay-sanjay -- fun fact, your work here found a bug in a future version on Julia! https://github.com/JuliaLang/julia/issues/53425#issuecomment-1958736378