JuliaHolomorphic / ComplexPhasePortrait.jl

Complex phase portraits for Julia.
Other
25 stars 9 forks source link

update for new Images: now images are just arrays, and I've permuted … #1

Closed dlfivefifty closed 7 years ago

dlfivefifty commented 7 years ago

…the dimensions so the output is correct

ehkropf commented 7 years ago

Thanks! I'll double check and merge this before the end of the day, provided nothing unexpected comes up. ;)

ehkropf commented 7 years ago

Running the sample code in the docs shows the orientation is wrong in the image output (x and y completely flipped?). The zeros and poles are in the wrong place. I unfortunately don't have time to chase it down right now. :( Check code below (compare with images on doc page).

using Images
using ComplexPhasePortrait

nx = 1000
x = linspace(-1, 1, nx)
Z = x' .+ flipdim(x, 1)*im

f(z) = (z - 0.5im).^2.*(z + 0.5+0.5im)./z
fz = f(Z)

img = portrait(fz)

If you have a different set of commands to get the proper orientation with your commit, the documentation could be changed to match.

dlfivefifty commented 7 years ago

Ah OK that can be corrected.

dlfivefifty commented 7 years ago

it should be fixed now

ehkropf commented 7 years ago

Thanks!