search

JuliaHomotopyContinuation / HomotopyContinuation.jl

A Julia package for solving systems of polynomials via homotopy continuation.
https://www.JuliaHomotopyContinuation.org
MIT License
175 stars 30 forks source link

Fix finding start pair linear in parameters #532

Closed ghost closed 1 year ago

ghost commented 1 year ago

Julia's nullspace(A) returns the result in some normal form. Sometimes the nullspace of A has dimension a lot more than 1, and in that case the first column will have a lot of zeros and picking it as p0 may result into picking a singular pair (x0, p0).

saschatimme commented 1 year ago

Thank you for the contribution. The change makes total sense. For the formatting you need to run the specified code https://github.com/JuliaHomotopyContinuation/HomotopyContinuation.jl/blob/6abf9c8de9c9c06ab4d02472c82eb3607ca8412d/.github/workflows/format_check.yml#L21-L22

[but I can also do this later today]

PBrdng commented 1 year ago

Hi Viktor, thank you for the quick fix. This is really helpful. I will fix the formatting later today.

saschatimme commented 1 year ago

Hi Viktor, thank you for the quick fix. This is really helpful. I will fix the formatting later today.

Just did the formatting :)