JuliaHomotopyContinuation / HomotopyContinuation.jl

A Julia package for solving systems of polynomials via homotopy continuation.
https://www.JuliaHomotopyContinuation.org
MIT License
184 stars 30 forks source link

sing_accuracy not recognised as endgame parameter #573

Closed AndrewGibbs closed 3 days ago

AndrewGibbs commented 4 months ago

In the documentation (and corresponding docstring), the endgame parameter singular_min_accuracy = 1e-6 appears incorrectly as sing_accuracy = 1e-12.

PBrdng commented 4 months ago

`sing_accuracy' is also an endgame parameter. Every zero with condition number above that value is considered singular.

AndrewGibbs commented 4 months ago

OK it appears that I was mistaken about the human cause of the issue - but there is still an issue. If I run

@var x y
F = System([x^2+y^2+1, 2x+3y-1], variables = [x, y])
solve(F, EndgameOptions(; sing_accuracy = 1e2))

Then I get the MethodError: no method matching EndgameOptions(; sing_accuracy=100.0)

AndrewGibbs commented 4 months ago

Thanks!

PBrdng commented 4 months ago

This is indeed weird. Thanks for noticing. I will look into it...

PBrdng commented 4 months ago

What is the version of Hc.jl that you use? Because in earlier version sing_accuracy was not implemented. In the most recent version of the software EndgameOptions(; sing_accuracy = 1e2) goes through on my computer.

AndrewGibbs commented 4 months ago

I'm using HomotopyContinuation v2.6.4. This was downloaded from the official Julia registry on Tuesday.

PBrdng commented 4 months ago

I think this is the problem. For some reason, the most recent version (2.9.3) is not automatically being installed on your device. I just tried a fresh installation and it gives me 2.9.3. There seems to be some compatibility conflict. Can you manually upgrade to 2.9.3?

AndrewGibbs commented 4 months ago

Perhaps it is because I am using an older version of Julia (1.7.2); are there dependencies on newer features? Uninstalling and reinstalling gives this message:

image

saschatimme commented 4 months ago

The latest HomotopyContinuation version requires at least Julia 1.8