search

JuliaHubOSS / llvm-cbe

resurrected LLVM "C Backend", with improvements
Other
826 stars 141 forks source link

Update LICENSE #105

Closed ViralBShah closed 3 years ago

ViralBShah commented 3 years ago

@vtjnash @Keno @StefanKarpinski Please see if this is ok, or can be done in a better way.

Keno commented 3 years ago

LLVM relicensed to Apache2 + LLVM exception. We should make our modifications available under both licenses in case someone wants to use it with a newer llvm.

ViralBShah commented 3 years ago

I do not know enough details about the new LLVM license to modify the license text appropriately. Feel free to directly edit this PR.

vtjnash commented 3 years ago

I think we may need to contact the LLVM legal team to clarify that. I think either our contributions are already automatically dual-licensed (since we signed the agreement for it), or the whole repo remains with the old license? It might be especially tricky, since we've gotten other outside contributions under this license since splitting of, and we can't just relicense those without confirmation from those authors for their patches here.

I would also say "changes" rather than "enhancements" so that there is clarity we meant all patches, not just new features.

vtjnash commented 3 years ago

c.f. https://github.com/JuliaComputingOSS/llvm-cbe/issues/87 for past discussion

hikari-no-yume commented 3 years ago

When I made #87 I initially thought about making a contribution that would change all the licence headers. But in the end I didn't, because (IANAL) the fact the old licence allows sublicensing means we can change to the new LLVM license at any time, so I didn't see a benefit of doing it immediately.

ViralBShah commented 3 years ago

I'm merging this - but if incorrectly done or there's a better way, please update accordingly.

hikari-no-yume commented 3 years ago

The copyright statement seems fine, insofar as it establishes the contributions from Julia Computing are owned by Julia Computing. Any contributions by outsiders aren't though, unless there was an explicit copyright assignment.

ViralBShah commented 3 years ago

Yes, that's right. We do not have a copyright assignment. Happy to update it to reflect better language. Perhaps something like this makes it clearer?

Copyright(c) 2015-2021 Julia Computing and contributors
hikari-no-yume commented 3 years ago

That sounds good to me.

ViralBShah commented 3 years ago

https://github.com/JuliaComputingOSS/llvm-cbe/commit/9fcf2cf1e988d1e1c04ca7a054ae83d2c6b6bfd7