Fix "add with overflow" intrinsic, remove maximum and minimum intrinsic

JuliaHubOSS / llvm-cbe

resurrected LLVM "C Backend", with improvements

Other

811 stars 138 forks source link

Fix "add with overflow" intrinsic, remove maximum and minimum intrinsic #179

Closed dpaoliello closed 1 year ago

dpaoliello commented 1 year ago

Adds tests for uadd.with.overflow and sadd.with.overflow intrinsics.
Fixes bug where uadd.with.overflow wasn't calculating the overflow correctly.
Fixes bug where headers weren't being included for generated intrinsic functions since headerUseXXX is being called after we've emitted the include declarations.
Removed maximum and minimum intrinsics as these were added in #164 but weren't properly implemented.

vtjnash commented 1 year ago

This CI addition is very great to have! (Also, you are welcome to merge things if you want too also. I just get a ping by the PR, and figure it is helpful for me glance over the content and then click the button.)