JuliaHubOSS / llvm-cbe

resurrected LLVM "C Backend", with improvements
Other
811 stars 138 forks source link

fix bug in printIntrinsicDefinition #198

Closed tonitick closed 2 months ago

tonitick commented 2 months ago

i should iterate over vectorSize instead of numParams

vtjnash commented 2 months ago

I agree, but seemed like CI thinks this method has a different name? Also style nit: this should use a call to cast, or a dyn_cast in the if statement instead of the isa

tonitick commented 2 months ago

looks like VectorType::getNumElements() is deprecated since llvm13: https://github.com/llvm/llvm-project/commit/49a6502cd5c2

use getElementCount().getKnownMinValue() instead.