search

JuliaIDE / Reminisce

Sublime-style saving of tabs and content for Light Table
10 stars 3 forks source link

Degrading Responsiveness #2

Open ghofmann opened 10 years ago

ghofmann commented 10 years ago

Hi there,

editing is getting slower and slower in the course of time , especially with large files. Reminisce stores open files and their contents in one single line in the file default.clj. Could this be the cause of the degrading responsiveness? I removed Reminisce and everything is back to normal.

Thanks for the great plugin otherwise.

Cheers Gerhard

MikeInnes commented 10 years ago

Sorry to hear you're having trouble with the plugin. Just to clarify, does restarting Light Table fix the performance issue or does it continue to degrade between sessions?

What OS are you on? I upgraded to Yosemite recently and I'm seeing similar issues, though it would be odd if Reminisce was the cause, since it doesn't actually do all that much.

I pushed an update recently which only caches file contents when necessary – let me know if that helps at all.

ghofmann commented 10 years ago

Nope, problem persists on my OX 10.9.3 and Windows 7 Enterprise machines. In VIM I see that the complete file content is being stored in Library/Application\ Support/LightTable/ltcache/default.clj. This a real show stopper with big files.

No such problem with Reminisce installed.

MikeInnes commented 10 years ago

OK, how big are the files you're working with? What I should probably do is just have a cap on the size of files which will be stored.

ghofmann commented 10 years ago

With big file I mean 20MB and bigger. You could make the cap on size configurable. Is default.clj really the proper place to store the complete workplace status?

MikeInnes commented 10 years ago

Ok, pretty big then, huh. I'll take a look at adding a cap.

default.clj seems like a reasonable place, it's just a generic cache – although I could perhaps create a dedicated file. Is that what you're thinking of? I'm open to suggestions anyway.

ghofmann commented 10 years ago

Yes, a separate cache for Reminisce would be great. The way Recall does it, I reckon. Just use default.clj for "small" things.

MikeInnes commented 10 years ago

I guess you're looking for this because you want default.clj to be readable/editable? Which is completely reasonable, I'm just checking there isn't another advantage that I've missed. I hadn't thought of this before because no other plugins that I know of actually use that cache, so I've never felt the need to edit it by hand myself.

ghofmann commented 10 years ago

Well, I think LightTable uses this file for its own book keeping. All sorts of things might happen interfering here, especially with huge entries. Just guessing, I'm not an expert on LightTable's inwards.

MikeInnes commented 10 years ago

Light Table itself actually doesn't store any state at all (hence the need for plugins like this :) – the only thing in default.clj by default is a UUID which is only set once. LT also provides an API for storing state in the cache, so I'm pretty sure plugin state like this is what it's designed for.

Anyway, I opened #3 for this, so when I'm working on Reminisce again I'll fix it up.

ghofmann commented 10 years ago

Much appreciated. Thank you for your kind support.